Dont send email notifications to banned users (fixes #1251)

New Pull Request

Conversation 3 Commits 2 Files Changed 2

Havent tested this yet.

I'd rather do this instead: https://github.com/LemmyNet/lemmy/issues/1255

Reason, a banned user might want to remove their email, matrix id, change their bio to remove identifying info, etc.

Regardless, there is no reason to send an email notification to a user who is banned and cant reply to the comment anyway. And I'm sure that not everyone is going to manually remove their email after being banned (they might not know that its possible).

I forgot to do the same change for private message notifications, best squash before merging.

Gotcha, I agree, plus you cleaned up my repeated code here too.

dessalines referenced this issue from a commit 4 months ago

Merge pull request 'Dont send email notifications to banned users (fixes #1251)' (#126) from dont-email-banned-user into main Reviewed-on: https://yerbamate.dev/LemmyNet/lemmy/pulls/126

dessalines merged commit 60517f8471 into main 4 months ago

The pull request has been merged as 60517f8471.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#126 Dont send email notifications to banned users (fixes #1251)