LemmyNet
/
lemmy
3
2
Fork 3
Code Pull Requests 1 Releases Wiki Activity
Labels Milestones

Explicitly mark posts and comments as public (ref #1220) #167

Merged
dessalines merged 1 commits from comments-posts-public into main 11 months ago
Conversation 0 Commits 1 Files Changed 3
nutomic commented 12 months ago
Owner

As discussed in #1220 (comment).

As discussed in [#1220 (comment)](https://github.com/LemmyNet/lemmy/issues/1220#issuecomment-776306378).
nutomic added 1 commit 12 months ago
dessalines reviewed 12 months ago
crates/apub/src/objects/mod.rs
.map(|a| a.as_xsd_any_uri().context(location_info!()))
.collect::<Result<Vec<&Url>, anyhow::Error>>()?;
for cid in community_ids {
let community = get_or_fetch_and_upsert_community(&cid, context, request_counter).await;
dessalines commented 12 months ago
Poster
Owner

I'm confused about this. Now a post is addressed to the community, and public, but public isn't upsertable. What happen when it encounters public() in this loop?

I'm confused about this. Now a post is addressed to the community, and public, but public isn't upsertable. What happen when it encounters `public()` in this loop?
nutomic commented 12 months ago
Poster
Owner

It returns an Err and doesn't go into the if below, so the value is skipped.

It returns an Err and doesn't go into the if below, so the value is skipped.
dessalines marked this conversation as resolved
dessalines merged commit f899831ed3 into main 11 months ago
The pull request has been merged as f899831ed3.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'comments-posts-public'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes