Dont include community in comment `to` field (fixes #1446) #174

Merged
dessalines merged 2 commits from no-community-in-comment-to into main 3 months ago
nutomic commented 3 months ago
Owner

This was actually much easier than I thought. Unfortunately I couldnt test if this fixes Pleroma federation, because the local federation setup throws errors when requesting something over HTTPS. I will try to put it up on a test server.

This was actually much easier than I thought. Unfortunately I couldnt test if this fixes Pleroma federation, because the local federation setup throws errors when requesting something over HTTPS. I will try to put it up on a test server.
nutomic added 1 commit 3 months ago
nutomic added 1 commit 3 months ago
Poster
Owner

I threw up the changes on test.lemmy.ml but its not working, lemmy-ui is giving this error:

lemmy-ui_1  | (node:1) UnhandledPromiseRejectionWarning: FetchError: invalid json response body at http://lemmy:8536/api/v2/site? reason: Unexpected endof JSON input
lemmy-ui_1  |     at /app/node_modules/node-fetch/lib/index.js:272:32
lemmy-ui_1  |     at processTicksAndRejections (internal/process/task_queues.js:93:5)
lemmy-ui_1  | (Use `node --trace-warnings ...` to show where the warning was created)
lemmy-ui_1  | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
lemmy-ui_1  | (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handledwill terminate the Node.js process with a non-zero exit code.

And doing curl 127.0.0.1:1235/api/v2/site on the server just hangs forever. Dont know whats going on, but I dont think its related to this PR.

A also added a commit to fix the lemmy_dev.yml playbook, seems like something changed there.

I threw up the changes on test.lemmy.ml but its not working, lemmy-ui is giving this error: ``` lemmy-ui_1 | (node:1) UnhandledPromiseRejectionWarning: FetchError: invalid json response body at http://lemmy:8536/api/v2/site? reason: Unexpected endof JSON input lemmy-ui_1 | at /app/node_modules/node-fetch/lib/index.js:272:32 lemmy-ui_1 | at processTicksAndRejections (internal/process/task_queues.js:93:5) lemmy-ui_1 | (Use `node --trace-warnings ...` to show where the warning was created) lemmy-ui_1 | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2) lemmy-ui_1 | (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handledwill terminate the Node.js process with a non-zero exit code. ``` And doing `curl 127.0.0.1:1235/api/v2/site` on the server just hangs forever. Dont know whats going on, but I dont think its related to this PR. A also added a commit to fix the lemmy_dev.yml playbook, seems like something changed there.
dessalines reviewed 3 months ago
) -> Result<Post, LemmyError> {
check_object_for_community_or_site_ban(page, context, request_counter).await?;
get_object_from_apub(page, context, expected_domain, request_counter).await
let post: Post = get_object_from_apub(page, context, expected_domain, request_counter).await?;
Poster
Owner

The other ones seem to do this too, so its prolly fine.

The other ones seem to do this too, so its prolly fine.
Poster
Owner

I dont know what you mean :p

I dont know what you mean :p
dessalines merged commit 6499709221 into main 3 months ago
The pull request has been merged as 6499709221.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.