New Pull Request

Remove categories (fixes #1429) #176

Merged

dessalines merged 2 commits from remove-categories into main 3 months ago

nutomic commented 3 months ago

Owner

This is a breaking change. We also need to update the docs, api docs and javascript client.

nutomic added 1 commit 3 months ago

be007b5638 Remove categories (fixes #1429 )

nutomic force-pushed remove-categories from be007b5638 to 3141ad31de 3 months ago

dessalines reviewed 3 months ago

migrations/2021-02-25-112959_remove-categories/down.sql Outdated

												
					('Meta'),
				
					('Other');
				
					ALTER TABLE community ADD category_id int references category on update cascade on delete cascade not null;

dessalines commented 3 months ago

Poster

Owner

Did you test this? I'd be surprised if it works since there's not a default value given (should probably be just 1). Its unavoidable but we lose all category info on the tables with this.

nutomic commented 3 months ago

Poster

Owner

I did (with diesel migration revert/run), but maybe I tested it wrong. Will add the default you suggested.

nutomic added 1 commit 3 months ago

72783edb17 In remove categories down migration, add default for category

dessalines commented 3 months ago

Owner

mmk, I'll test this locally too.

dessalines merged commit 7c87da012e into main 3 months ago

dessalines referenced this issue from a commit 3 months ago

Merge pull request 'Remove categories (fixes #1429)' (#176) from remove-categories into main

The pull request has been merged as 7c87da012e.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.